Divide and conquer traverse 2 #78
Conversation
Fixes test of parent commit, 6eb97e5.
Also use a type synonym to simplify type signatures in Test.Main
Also add comment to explain why it is this way.
|
@S11001001 @hdgarrood Does this look okay to everyone now? I assume it's been reviewed several times already 😄 |
hdgarrood
left a comment
There was a problem hiding this comment.
There are some fairly significant changes to the tests that don't seem related. I'd rather not do all this together.
| import Unsafe.Coerce (unsafeCoerce) | ||
|
|
||
| foreign import arrayFrom1UpTo :: Int -> Array Int | ||
| foreign import arrayReplicate :: forall a. Int -> a -> Array a |
There was a problem hiding this comment.
Could you please leave this as it was?
|
|
||
| import Test.Assert (ASSERT, assert, assert') | ||
| import Unsafe.Coerce (unsafeCoerce) | ||
|
|
There was a problem hiding this comment.
Could you explain the reason for this change?
| minimumBy (compare `on` abs) | ||
| (map (negate <<< Int.toNumber) (arrayFrom1UpTo 10)) | ||
| (map (negate <<< toNumber) (arrayFrom1UpTo 10)) | ||
| == Just (-1.0) |
There was a problem hiding this comment.
Surely we're already pulling this in as a dependency?
|
Oh I see, they're from merging master. Ok then. 👍 |
|
The signatures aren't like that in master. Those were probably in conflict and maybe I resolved with that. I'll leave it as master but unifying |
|
@jacereda, @S11001001 thanks for doing this, sorry it took so absurdly long to get merged! |
This is #54 relative to current master.