Doc HSPEC_ACCEPT; verify Main module exists in PS tests
#4243
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JordanMartinez
commented
Feb 24, 2022
4 tasks
Contributor
Author
|
|
rhendric
approved these changes
Feb 24, 2022
Member
rhendric
left a comment
There was a problem hiding this comment.
Pending removal of the test that proves the check works, LGTM.
Contributor
Author
Looks like I already pushed this back in 0230ca0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
Related to #4192, but documents the
HSPEC_ACCEPTflag, which is stated in a non-obvious place hereFixes the issue discovered in #4240 (comment). To verify this fix works, I'll push a commit not doing that and get a failure in CI before pushing a commit that reverts that.
Checklist: