Fix Windows only problem of wrapper command built by npm #140
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
This makes |
Collaborator
|
E.g. one test run I tried results in this: Maybe the problem arises from these source globs not being quoted? |
Collaborator
|
It seems you'd have to fiddle with both String and Text related code to quote all of these (e.g. justinwoo@e008bd9), and it still feels a bit iffy as you can pass through options to the compiler. Maybe someone will have another opinion about this. |
Contributor
Author
|
Well, I see... |
Contributor
Author
|
I understood that there are many problems this PR. I'll rethink. Thank you for your reviewing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rel: #34, #69, #138
-- I'm sorry. I'm not good at English.
psc-package command can't exec
purs, if it is installed by npm command.Although I tried to solve it, I found that it is a constraint of
System.Process.createProcessorSystem.Process.runProcess.It works if instead use
System.Process.shellorSystem.Process.runCommand.This PR is another approach of #69.
Thank you.