The MessageHandler should not return `null` but throw a `DBusException`

My new `MessageHandler` avoids returning `null` on my `2.0.0` branch as this only leads to problems, if the case is not handled properly.

https://github.com/purejava/kdewallet/blob/acd9595106a958b08fec97b2cc01cc771f445468/src/main/java/org/freedesktop/dbus/handlers/MessageHandler.java#L30-L55

**see:** https://github.com/swiesend/secret-service/blob/c7399ea1f2d6031158a64a0459a066a35c7f9cbf/src/main/java/org/freedesktop/secret/handlers/MessageHandler.java#L34-L75

**see also:** https://github.com/swiesend/secret-service/issues/6

	public Object[] send(String service, String path, String iface, String method, String signature, Object... args) {
	try {
	org.freedesktop.dbus.messages.Message message = new MethodCall(
	service,
	path,
	iface,
	method, (byte) 0, signature, args);

	connection.sendMessage(message);

	org.freedesktop.dbus.messages.Message response = ((MethodCall) message).getReply(2000L);
	log.trace(response.toString());

	if (response instanceof org.freedesktop.dbus.errors.Error) {
	throw new DBusException(response.getName() + ": " + response.getParameters()[0]);
	}

	Object[] parameters = response.getParameters();
	log.debug(Arrays.deepToString(parameters));
	return parameters;

	} catch (DBusException e) {
	log.error(e.toString(), e.getCause());
	}
	return null;
	}

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

The MessageHandler should not return `null` but throw a `DBusException` #1

Metadata

Assignees

Labels

Projects

Milestone

Relationships

Development

Uh oh!

The MessageHandler should not return null but throw a DBusException #1

Description

Metadata

Metadata

Assignees

Labels

Projects

Milestone

Relationships

Development

Issue actions

The MessageHandler should not return `null` but throw a `DBusException` #1