ci: always generate screenshots before deploying docs#409
Merged
edouard-lopez merged 1 commit intopure-fish:masterfrom Mar 2, 2026
Merged
ci: always generate screenshots before deploying docs#409edouard-lopez merged 1 commit intopure-fish:masterfrom
edouard-lopez merged 1 commit intopure-fish:masterfrom
Conversation
Screenshots were only generated when tools/screenshot.fish changed, but since the PNGs aren't committed to the repo, every other docs deployment produced a site with missing screenshot images (404s). Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Member
|
Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
All screenshot images on the documentation site return 404 (e.g. this one).
The screenshot
.pngfiles are not committed to the repo — they're generated at build time bytools/screenshot.fishrunning in Docker. However, the generation steps in the docs workflow were conditional: they only ran whentools/screenshot.fishitself had changed (viatj-actions/changed-files) or on manualworkflow_dispatch. On every other docs deployment, the screenshots were skipped, resulting in a site with no images.This PR removes the conditional checks so screenshots are always generated before MkDocs deploys the site.
Test plan
make build-pure-screenshotandmake run-pure-screenshotfollowed bymake serve-pure-doc— all 84 screenshots (42 configs × light/mirage) generated successfully and rendered on the docs site🤖 Generated with Claude Code