---

This section details on the original issue you should resolve

<issue_title>Remove fish_greeting.fish from this prompt</issue_title>
<issue_description>Installing this prompt overrides my own fish_greeting.fish file. While I understand its nice to get rid of the default fish greeting, shouldn't that be the responsibility of the user or a separate plugin, and not the responsibility of a prompt?

In other words, I feel it should be possible to mix and match prompts and greetings, rather than one controlling the other.

On another note: thanks very much for this prompt - I particularly like how the arrow direction switches with fish's vim mode - that's much more subtle than any mode indicator I had devised!</issue_description>

<agent_instructions>Could you make a pull request regarding this issue. Check the contributing.md for the coding style and the PR template for the requirements</agent_instructions>

Comments on the Issue (you are @copilot in this section)

@edouard-lopez Hello @neon64, thanks for the feedback.

Was you fish_greeting.fish located in $HOME/.config/fish/functions/fish_greeting.fish? That's where installer place our fish_greeting.fish file, its the recommended way to leverage autoload mechanism.

Solution

You can either remove $HOME/.config/fish/functions/fish_greeting.fish and fallback to your setup or copy your setup in it.

Discussion

I understand your point about responsability but pure vision is to provide a clean and pure experience of the prompt. So, removing greeting and other presets sounds in line with this.

However, one is free to customize upon it as described above.

Cheers!</comment_new>
<comment_new>@edouard-lopez
Thanks for the feedback, do you think I can automate the addition of the call?</comment_new>
<comment_new>@edouard-lopez

Current Behaviour

Currently, on new session, pure checks for new release and show command to install, as we override the fish_greeting.fish file.

Proposed Behaviour

⚠️ Introduce a breaking change in pure's behaviour that will require user action.

• Stop overriding user functions/fish_greeting.fish
• Document how to add the new release check
• Suppress Fish's default greeting, as suggested by @jorgebucaran
• Provide instructions to stdout on install as suggested by @wjagodfrey

Does that sound right, to you?</comment_new>
<comment_new>@edouard-lopez

You could also follow the pattern of extending the file if it exists,

How would you do that programmatically?

provide instructions to stdout on install

That's a good idea!</comment_new>
<comment_new>@edouard-lopez
@jorgebucaran I defined a custom fish_greeting function in the project. I believe @wjagodfrey own file is being overwritten during install. Emptying fish_greeting variable won't resolve the issue when people have added a custom fish_greeting function.

However, we can:

1. rename the project's fish_greeting.fish to _pure_fish_greeting.fish so it doesn't override user file ;

2. add a post_install event handler that check the situation so that:

   • when fish_greeting.fish is missing, use our (i.e. rename _pure_fish_greeting.fish as fish_greeting.fish) ;

   • when fish_greeting.fish already exists, output instruction to add call to _pure_check_for_new_release:

     echo "_pure_check_for_new_release" >> $fish_function_path/fish_greeting.fish
     

@wjagodfrey I'm open to PR, here are some entry points:

• https://github.com/pure-fish/pure/blob/master/CONTRIBUTING.md ;
• basic test for the event handler https://github.com/pure-fish/pure/blob/master/tests/_pure_uninstall.test.fish
• for the post_install event handler, you can put it in https://github.com/pure-fish/pure/blob/master/conf.d/_pure_init.fish

The project has a docker container you can use (cf. makefile)</comment_new>