fix(vscode): prevent vscode from adding extra line#381
Merged
edouard-lopez merged 3 commits intomasterfrom Sep 22, 2025
Merged
Conversation
Member
Author
|
@Perlence @MrAru could you try this PR in VSCode. Failed MacOS testsHowever, I noted it's messing test on MacOS. Checking Single Line featureCould you also check in a normal terminal for any issue related to If the rendering is correct, I will fix the test. Otherwise, I will have to weight the time to debug (I don't have MacOS) versus the added value of the feature with shell integration enabled in vscode. |
|
I can confirm that this fix works in VS Code. I think the single-line prompt renders correctly. Here's Terminal.app:
And here's Alacritty 0.15.1:
@edouard-lopez Thanks for debugging and fixing this! ❤️ |
34e67cb to
b41a5d7
Compare
adcd081 to
22a009f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Thanks to @wyw message
microsoft/vscode#187185 (comment)
Test
terminal.integrated.shellIntegration.enabledsettingsfixes #341 #379