fix: add shepherd to the list of supported init programs#354
Merged
edouard-lopez merged 2 commits intopure-fish:masterfrom May 20, 2025
Merged
fix: add shepherd to the list of supported init programs#354edouard-lopez merged 2 commits intopure-fish:masterfrom
edouard-lopez merged 2 commits intopure-fish:masterfrom
Conversation
This makes it so that 'username@host' is not spuriously displayed on Guix System.
Member
|
Thanks for the PR! Please review the Acceptance Checks. |
Contributor
Author
|
@edouard-lopez I added a testcase and ran the tests according to your instructions against fish 3.3.1 (the example in the contributing guide) and 3.7.0 (the latest versions available on dockerhub?) and they all passed. I read through the acceptance checks but most don't seem relevant for this contribution (i.e. this is not a feature with associated configuration variables etc.) AFAICT I am in compliance with the checks, but let me know what you think! |
| before_each | ||
| @test "_pure_detect_container_by_pid_method: false when detecting shepherd in /proc/1/sched" ( | ||
| _create_proc_sched_file $proc_sched | ||
| echo "shepherd (1, #threads: 1)" >$proc_sched |
Member
There was a problem hiding this comment.
I'm not familiar with shepherd, but look like that the correct approach .
edouard-lopez
approved these changes
May 20, 2025
edouard-lopez
approved these changes
May 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes it so that 'username@host' is not spuriously displayed on Guix System when not running in a container.
related: fixes #353