Skip to content

Remove font family hack#1074

Merged
redonkulus merged 3 commits intopure-css:masterfrom
septatrix:remove-font-family-hack
Oct 26, 2022
Merged

Remove font family hack#1074
redonkulus merged 3 commits intopure-css:masterfrom
septatrix:remove-font-family-hack

Conversation

@septatrix
Copy link
Contributor

This eliminates the confusing font override on grids. The respective "supported browsers" section in the readme should also be adjusted though I am not sure how to proceed there as I am not exactly sure how this affects old browsers other than IE (especially old Android).

Setting font-family and letter spacing was required for IE
and some other ancient browsers.
These are no longer supported, thus we can remove the hacks.
Copy link
Contributor

@redonkulus redonkulus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@redonkulus
Copy link
Contributor

redonkulus commented Oct 25, 2022

@septatrix one lint error:

Error: 1:8 error 'Link' is defined but never used no-unused-vars

@septatrix
Copy link
Contributor Author

Fixed

@redonkulus redonkulus merged commit 6084e90 into pure-css:master Oct 26, 2022
@redonkulus
Copy link
Contributor

@septatrix This has now been released in version 3.0.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants