fix: add support for relative install paths to BrowserFetcher (#7613)

nadir · web-flow · commit eebf452d38b7 · 2021-09-29T14:21:38.000Z
This patch fixes the BrowserFetcher._getFolderPath method so that it supports relative download paths using PUPPETEER_DOWNLOAD_PATH or npm config Issues: #7592
diff --git a/src/node/BrowserFetcher.ts b/src/node/BrowserFetcher.ts
@@ -419,7 +419,7 @@ export class BrowserFetcher {
    * @internal
    */
   _getFolderPath(revision: string): string {
-    return path.join(this._downloadsFolder, `${this._platform}-${revision}`);
+    return path.resolve(this._downloadsFolder, `${this._platform}-${revision}`);
   }
 }
 

Original file line number	Diff line number	Diff line change
`@@ -419,7 +419,7 @@ export class BrowserFetcher {`
`419`	`419`	`* @internal`
`420`	`420`	`*/`
`421`	`421`	`_getFolderPath(revision: string): string {`
`422`		- return path.join(this._downloadsFolder, `${this._platform}-${revision}`);
	`422`	+ return path.resolve(this._downloadsFolder, `${this._platform}-${revision}`);
`423`	`423`	`}`
`424`	`424`	`}`
`425`	`425`