Fix: sharing app instances with different hostnames not working #281
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes a problem where it fails to reuse the same instance of the app when using multiple hostnames with different names (multiple symlinks pointing to the same folder). The bug was introduced in puma#270. The patch is based on adding the checksum in all cases when a symlink is involved, not only when the names don't match. If not, it can happen that it's not added if the name matches for the first execution, which results in not finding the app instance later, resulting in an error "There is already a server bound to..." Fixes puma#280
Member
|
Thanks @jorgemanrubia! |
Contributor
Author
|
Thanks for merging @nonrational. Any chance we can get a brew release with this one 🙏? |
Member
|
@jorgemanrubia v0.16.1 is now available at |
Contributor
Author
|
Thank you @nonrational 🙏🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a problem where it fails to reuse the same instance of the app when using multiple hostnames with different names (multiple symlinks pointing to the same folder).
The bug was introduced in #270. The patch is based on adding the checksum in all cases when a symlink is involved, not only when the names don't match. If not, it can happen that it's not added if the name matches for the first execution, which
results in not finding the app instance later, resulting in an error "There is already a server bound to..."
Fixes #280
cc @hellvinz @nonrational