Skip to content

Update vendored github.com/fsnotify/fsevents #188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nateberkopec merged 1 commit into from
Aug 21, 2019
Merged

Update vendored github.com/fsnotify/fsevents #188

nateberkopec merged 1 commit into from
Aug 21, 2019

Conversation

@lmars
Copy link
Contributor

@lmars lmars commented Jan 2, 2019

To pull in the following fix:

fsnotify/fsevents#41

@lmars
Update vendored github.com/fsnotify/fsevents
f366088 
To pull in the following fix:

fsnotify/fsevents#41

Signed-off-by: Lewis Marshall <lewis@lmars.net>
@nonrational nonrational mentioned this pull request Aug 21, 2019
Closed
@nateberkopec
Copy link
Member

nateberkopec commented Aug 21, 2019

I may be missing something here, but this does not fix the issue for me.

On a freshly cloned puma-dev, with this branch checkout out:

 speedshop $ go build ./cmd/puma-dev
# github.com/puma/puma-dev/vendor/github.com/fsnotify/fsevents
../../../../go/src/github.com/puma/puma-dev/vendor/github.com/fsnotify/fsevents/wrap.go:115:59: cannot use nil as type _Ctype_CFAllocatorRef in assignment
../../../../go/src/github.com/puma/puma-dev/vendor/github.com/fsnotify/fsevents/wrap.go:122:42: cannot use nil as type _Ctype_CFAllocatorRef in assignment
../../../../go/src/github.com/puma/puma-dev/vendor/github.com/fsnotify/fsevents/wrap.go:175:37: cannot use nil as type _Ctype_CFAllocatorRef in argument to _Cfunc_CFStringCreateWithCString

...which is the same error I get on master.

@lmars
Copy link
Contributor Author

lmars commented Aug 21, 2019

It works for me:

$ git reflog show HEAD
f366088 (HEAD -> update-fsevents, lmars/update-fsevents) HEAD@{0}: commit: Update vendored github.com/fsnotify/fsevents

$ go build ./cmd/puma-dev

$ echo $?
0

@nateberkopec
Copy link
Member

nateberkopec commented Aug 21, 2019

Newbie GOPATH issues, sorry. Confirmed fixed.

@nateberkopec nateberkopec merged commit 70121c7 into puma:master Aug 21, 2019
@lmars
Copy link
Contributor Author

lmars commented Aug 21, 2019

Good ol' GOPATH 😉

Thanks for the merge!

@lmars lmars deleted the update-fsevents branch August 21, 2019 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

bug

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@lmars @nateberkopec