Skip to content

test/rackup/ci_*.ru files - cache response bodies#2952

Merged
MSP-Greg merged 1 commit intopuma:masterfrom
MSP-Greg:00-bench-cache-bodies
Sep 13, 2022
Merged

test/rackup/ci_*.ru files - cache response bodies#2952
MSP-Greg merged 1 commit intopuma:masterfrom
MSP-Greg:00-bench-cache-bodies

Conversation

@MSP-Greg
Copy link
Copy Markdown
Member

@MSP-Greg MSP-Greg commented Sep 13, 2022

Description

When using the test/rackup/ci_*.ru files, previous (original) versions did not cache response bodies. Larger bodies may use a lot of memory, causing gc issues, etc. This affects performance benchmarks.

Hence, cache bodies so benchmark results are more accurate.

Your checklist for this pull request

  • I have reviewed the guidelines for contributing to this repository.
  • I have added (or updated) appropriate tests if this PR fixes a bug or adds a feature.
  • My pull request is 100 lines added/removed or less so that it can be easily reviewed.
  • If this PR doesn't need tests (docs change), I added [ci skip] to the title of the PR.
  • If this closes any issues, I have added "Closes #issue" to the PR description or my commit messages.
  • I have updated the documentation accordingly.
  • All new and existing tests passed, including Rubocop.

@MSP-Greg MSP-Greg merged commit 0e832e7 into puma:master Sep 13, 2022
@MSP-Greg MSP-Greg deleted the 00-bench-cache-bodies branch September 13, 2022 03:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant