test/rackup/ci_*.ru files - fix frozen string issue#2951
Merged
MSP-Greg merged 1 commit intopuma:masterfrom Sep 12, 2022
Merged
test/rackup/ci_*.ru files - fix frozen string issue#2951MSP-Greg merged 1 commit intopuma:masterfrom
MSP-Greg merged 1 commit intopuma:masterfrom
Conversation
Member
|
Has it failed in CI? Do you have a link? |
Member
Author
|
None of the new rackup files are used in CI. they're used in the files added in benchmarks/local files. The error happened when testing PR #2896 with Ruby 2.7. Locally, I mostly test with Ruby master. |
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Interesting problem. Ruby 3 doesn't throw a 'frozen string' error, but Ruby 2.7 does. Fixed.
Your checklist for this pull request
[ci skip]to the title of the PR.#issue" to the PR description or my commit messages.