update to use pulumi-kuberentes 2.0+ and kubernetes client-go 1.18#78
Merged
lblackstone merged 3 commits intopulumi:masterfrom Oct 9, 2020
Merged
update to use pulumi-kuberentes 2.0+ and kubernetes client-go 1.18#78lblackstone merged 3 commits intopulumi:masterfrom
lblackstone merged 3 commits intopulumi:masterfrom
Conversation
Contributor
|
Hi @nicks We will get this reviewed / testing / merged and released before your talk! Thanks so much for doing this Paul |
Member
|
Hey @nicks, thanks for the PR! I PR'd a small change to your branch and spot-checked it locally. LGTM once tilt-dev#1 lands |
go mod tidy
Contributor
Author
|
updated! |
lblackstone
approved these changes
Oct 9, 2020
Member
|
@nicks I cut a new release that includes this change: https://github.com/pulumi/kubespy/releases/tag/v0.6.0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi! I'm giving a talk at Kubecon in November. A section of it discusses some things I admire about how kubespy uses client-go.
In order to show this off, it would help me a lot if this was on a newer version of client-go!
I saw you had an issue open about upgrading modules (#70), so I took the liberty of sending a PR. I'm not sure how opinionated this code is about use of the kubernetes client and open to change it.
Thanks!
Fix #70