Skip to content

Set range end to Paragraph if returned early because of footnote definition#831

Merged
Martin1887 merged 1 commit intopulldown-cmark:branch_0.9.3from
GuillaumeGomez:footnote-def
Jan 28, 2024
Merged

Set range end to Paragraph if returned early because of footnote definition#831
Martin1887 merged 1 commit intopulldown-cmark:branch_0.9.3from
GuillaumeGomez:footnote-def

Conversation

@GuillaumeGomez
Copy link
Contributor

My deepest apologies, I didn't notice but the end range was not filled and it panicked when running rustdoc on the code I used for the test. I fixed it and added a regression test to ensure the range is always filled as expected.

Can you yank the 0.9.4 version and release the 0.9.5 please? Again, I'm very sorry for not noticing the bug earlier on.

@Martin1887 Martin1887 merged commit 3e1550c into pulldown-cmark:branch_0.9.3 Jan 28, 2024
@Martin1887
Copy link
Collaborator

No problem, version 0.9.5 has just been released and 0.9.4 is yanked.

@GuillaumeGomez
Copy link
Contributor Author

Thanks a lot!

@Martin1887
Copy link
Collaborator

0.9.6 just released updating Cargo.lock and 0.9.5 yanked to fix #833.

@GuillaumeGomez
Copy link
Contributor Author

Thanks! :)

@Martin1887
Copy link
Collaborator

No need of 'frontporting' to 0.10, this was already implemented as the new footnotes in #654.

@GuillaumeGomez
Copy link
Contributor Author

@Martin1887
Copy link
Collaborator

It is fixed in the new footnotes type, fully compatible with GitHub, but it does not in the old type. Probably convenient to have the same behavior than 0.9.6...

@GuillaumeGomez
Copy link
Contributor Author

It is not based on what is in https://github.com/raphlinus/pulldown-cmark/blob/master/specs/footnotes.txt.

You can't do (as is, you won't have two footnote definitions):

Lorem ipsum.[^a] [^missing]

[^a]: def1
[^missing]: def2

@Martin1887
Copy link
Collaborator

OK, I had only checked the spec test with two consecutive footnotes without an empty line between them. So this could be applied to the two types of footnotes then.

Thanks!

@GuillaumeGomez
Copy link
Contributor Author

So I'll try to backport my PR as mentioned in the coming days (might be tricky with me needing to prep for FOSDEM) or next week. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants