Conversation
| static HTML_ESCAPE_TABLE: [u8; 256] = create_html_escape_table(); | ||
|
|
||
| static HTML_ESCAPES: [&str; 5] = ["", """, "&", "<", ">"]; | ||
| static HTML_ESCAPES: [&str; 6] = ["", """, "&", "<", ">", "'"]; |
There was a problem hiding this comment.
In rustdoc, we have two escape functions: one used in attributes, and the other in body text. It's an easy way to avoid lots of bloat from escaping apostrophes and double quotes, which are very common in both English text and Rust source code.
There was a problem hiding this comment.
Well, I think that would be an enhancement, but a bit of bloat is preferable to security issues :). If you can work in crate the separated escape function we can merge that, but I think we can merge this meanwhile (when tests pass, I have to check why it is not working using simd), what do you think?
There was a problem hiding this comment.
Really weird, I don't get why the '39' (b'\'') is not replaced in sim, it does not nothing special.
There was a problem hiding this comment.
I think you forgot to update this thing:
There was a problem hiding this comment.
Right, I missed that, thanks!
|
Closed in favor of #830. |
Fix #598