Skip to content

Clean up some more gratuitous differences in footnote parsing#773

Merged
Martin1887 merged 1 commit intopulldown-cmark:masterfrom
notriddle:notriddle/no-such-thing-as-collapsed-footnote-refs
Nov 4, 2023
Merged

Clean up some more gratuitous differences in footnote parsing#773
Martin1887 merged 1 commit intopulldown-cmark:masterfrom
notriddle:notriddle/no-such-thing-as-collapsed-footnote-refs

Conversation

@notriddle
Copy link
Collaborator

@notriddle notriddle commented Nov 2, 2023

  • This reverses the choice to diverge from GitHub on the
    issue of back-to-back [shortcut links][^and footnotes],
    since other implementations of this feature also do it.
  • This stops pulldown-cmark from trying to parse [^collapsed][]
    footnote references. Those aren't a thing.

Fixes #772

* This reverses the choice to diverge from GitHub on the
  issue of back-to-back `[shortcut links][^and footnotes]`,
  since other implementations of this feature also do it.
* This stops pulldown-cmark from trying to parse `[^collapsed][]`
  footnote references. Those aren't a thing.

Fixes pulldown-cmark#772
@notriddle notriddle force-pushed the notriddle/no-such-thing-as-collapsed-footnote-refs branch from 0c11b0c to 1d45531 Compare November 2, 2023 21:51
@notriddle notriddle changed the title No such thing as [^foo][] collapsed footnote references Clean up some more gratuitous differences in footnote parsing Nov 2, 2023
@Martin1887 Martin1887 merged commit f4dc0b6 into pulldown-cmark:master Nov 4, 2023
@notriddle notriddle deleted the notriddle/no-such-thing-as-collapsed-footnote-refs branch November 4, 2023 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[fuzz results] empty square brackets after footnote reference silently eaten

2 participants