Use original run lengths to judge multiples of three#730
Merged
Martin1887 merged 2 commits intopulldown-cmark:masterfrom Oct 19, 2023
Merged
Use original run lengths to judge multiples of three#730Martin1887 merged 2 commits intopulldown-cmark:masterfrom
Martin1887 merged 2 commits intopulldown-cmark:masterfrom
Conversation
The phrase that the specification uses is: > If one of the delimiters can both open and close emphasis, then > the sum of the lengths of the delimiter runs containing the opening > and closing delimiters must not be a multiple of 3 unless both > lengths are multiples of 3. Pulldown-cmark considered a run to be split, and its size reduced, when it participated in an emphasis span, but other implementations seem to use the *original* length of the emphasis span to judge this rule.
a6f21e0 to
62449cb
Compare
Collaborator
|
Cool, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #729
The phrase that the specification uses is:
Pulldown-cmark considered a run to be split, and its size reduced, when it participated in an emphasis span, but other implementations seem to use the original length of the emphasis span to judge this rule.