Fix incorrect scan of bad email address#688
Merged
Martin1887 merged 1 commit intomasterfrom Jul 5, 2023
Merged
Conversation
The old scanner mistakenly accepted an email address with an empty label before the @ symbol. This commit also adds some hand-written tests. I also ran a bit of property testing against the regex. Also renumbers regression tests that were incorrectly numbered (probably due to merge conflict). Fixes #687
Collaborator
Author
|
If people want to replicate my property testing (which is admittedly not very sophisticated), here's a gist. It was able to detect the reported issue, but not artificially induced bugs in label length, likely because the probability of a randomly generated label being valid gets very small as the length increases. A better strategy would be to generate a good email address from the regex, then mutate one byte. I didn't do that, but perhaps somebody is motivated to. |
Collaborator
|
Great! |
Collaborator
|
Cool, that was much easier than I thought! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The old scanner mistakenly accepted an email address with an empty label before the @ symbol.
This commit also adds some hand-written tests. I also ran a bit of property testing against the regex.
Also renumbers regression tests that were incorrectly numbered (probably due to merge conflict).
Fixes #687