Fix spec violation on empty-list-item-cannot-interrupt-paragrph rule#681
Merged
Martin1887 merged 1 commit intopulldown-cmark:masterfrom Jul 1, 2023
Merged
Conversation
72122e3 to
f32e71e
Compare
Martin1887
reviewed
Jun 29, 2023
Collaborator
|
Thanks for your contribution, it looks fine. |
f32e71e to
38f2ffe
Compare
Collaborator
Author
|
@Martin1887 Yeah, that file should not be there. |
> The following rules define > [list items](https://spec.commonmark.org/0.30/#list-items): > > 1. Basic case. If a sequence of lines Ls constitute a sequence of > blocks Bs starting with a character other than a space or tab, > and M is a list marker of width W followed by 1 ≤ N ≤ 4 spaces of > indentation, then the result of prepending M and the following > spaces to the first line of Ls*, and indenting subsequent lines > of Ls by W + N spaces, is a list item with Bs as its contents. > The type of the list item (bullet or ordered) is determined by > the type of its list marker. If the list item is ordered, then it > is also assigned a start number, based on the ordered list marker. > > Exceptions: > 1. When the first list item in a list interrupts a paragraph— > that is, when it starts on a line that would otherwise count > as paragraph continuation text—then (a) *the lines Ls must > not begin with a blank line*, and (b) if the list item is > ordered, the start number must be 1.
38f2ffe to
31014ed
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #680
This was definitely a spec violation. Emphasis mine.