Skip to content

Block quotes interrupt paragraphs even with no space at start#675

Merged
Martin1887 merged 1 commit intopulldown-cmark:masterfrom
notriddle:notriddle/issue-674
Jun 25, 2023
Merged

Block quotes interrupt paragraphs even with no space at start#675
Martin1887 merged 1 commit intopulldown-cmark:masterfrom
notriddle:notriddle/issue-674

Conversation

@notriddle
Copy link
Collaborator

Fixes #674

@Martin1887
Copy link
Collaborator

I'm wondering if this solves only the case when the > is not followed by space. I guess the following would interpret a blockquote meanwhile it should close the div, right?

<div
> thing that follows the div, not blockquote
.
<p>
<div
</p>
<blockquote>thing that follows the div, not blockquote</blockquote>

Thanks!

@notriddle notriddle force-pushed the notriddle/issue-674 branch from 76db469 to 8c949ad Compare June 24, 2023 13:17
@notriddle
Copy link
Collaborator Author

I'm wondering if this solves only the case when the > is not followed by space.

It solves both cases. I've added another regression test for the case where it is followed by a space.

@notriddle notriddle force-pushed the notriddle/issue-674 branch from 8c949ad to cea06bc Compare June 24, 2023 13:18
@Martin1887 Martin1887 merged commit 8427106 into pulldown-cmark:master Jun 25, 2023
@Martin1887
Copy link
Collaborator

Perfect, merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

HTML has higher priority than block quotes

2 participants