Implement Debug for all public types#611
Merged
marcusklaas merged 3 commits intopulldown-cmark:masterfrom Sep 8, 2022
gifnksm:impl-debug
Merged
Implement Debug for all public types#611marcusklaas merged 3 commits intopulldown-cmark:masterfrom gifnksm:impl-debug
Debug for all public types#611marcusklaas merged 3 commits intopulldown-cmark:masterfrom
gifnksm:impl-debug
Conversation
marcusklaas
reviewed
Sep 7, 2022
Collaborator
|
Thanks for the PR. I left one comment on the code. Once that's addressed, this is good to go. |
Contributor
Author
|
Thank you for your review. I have addressed your comment. |
Collaborator
|
Merged. Thanks for your contribution! |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request implements
Debugfor all public types detected bymissing-debug-implementationslint.This also enables the lint checking by default so that similar problems can be detected in the future.
fixes #609