Fix the crash when hashing an async function#90
Conversation
|
I had to add a workaround for the old browserify build system. There's already one workaround there, so a second didn't seem too bad. The workaround only applies to the bundled code run with Karma. The tests run from Node still run with the original non-bundled code. The tests pass for everything except Node 6, which didn't support async functions. Node 6 reached end-of-life back in April. Maybe it's time to drop support for it? |
|
Node 6 reached EOL last decade. The tests pass for Node >= 8. That probably means a major version bump. There are no other breaking changes. |
|
@addaleax any word on this? Currently facing this problem in TSDX in several issues: jaredpalmer/tsdx#294 , jaredpalmer/tsdx#358 (comment) , jaredpalmer/tsdx#278 (comment) , and a few in jaredpalmer/tsdx#379 TSDX is using You had said you would look into this back then in #68 (comment) and then there was never an update ( This approach should also work for async generator functions as they come out as |
|
@agilgur5 I was happily using TSDX until I tried to use |
|
@arvinsim It is one of the top issues in TSDX, particularly with how frequently it's referenced. A good chunk of people are definitely using the And unfortunately it can't be monkey-patched and can't easily be patched with a fork as it's a transitive dependency 😕 |
|
Yeah, all I need to do is to fix this test up so that instead of the last commit there is actual support for Node.js 6 … will do that now |
31a27e5 to
8705eec
Compare
Co-authored-by: Anna Henningsen <anna@addaleax.net>
8705eec to
2879144
Compare
|
Should be fixed in v2.0.2 now |
|
Thanks so much for the quick response & release @addaleax !! |
Fixes #67.
This code will no longer crash: