Skip to content

Support async functions#68

Closed
wessberg wants to merge 2 commits into
puleos:masterfrom
wessberg:master
Closed

Support async functions#68
wessberg wants to merge 2 commits into
puleos:masterfrom
wessberg:master

Conversation

@wessberg

@wessberg wessberg commented Mar 25, 2018

Copy link
Copy Markdown

This PR fixes #67 .

It simply adds checks for async functions where functions are expected.

@addaleax

Copy link
Copy Markdown
Collaborator

@wessberg Thanks, but I don’t think this quite works yet – asyncfunction is not the result of typeof, it’s coming from the result of Object.prototype.toString.call(async function() {}).

(Also, feel free to omit the dist/ changes in PRs – they are overwritten anyway and don’t interact well with git.)

I’ll try to get this fixed soon, but the approach would probably require using something like the _function entry. Also, I think at this point both generator functions and async generator functions are unsupported as well, and would likely need to be addressed in a similar manner as normal async functions.

@addaleax

addaleax commented Oct 7, 2019

Copy link
Copy Markdown
Collaborator

Closing as there hasn’t been any reply in a long time

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Doesn't support async functions

2 participants