Wrapped a handful of time64 functions#969
Merged
ptitSeb merged 1 commit intoptitSeb:masterfrom Jun 15, 2024
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR wraps several time64 functions and enables time64 builds.
I've tested the new wrapped functions in both configurations (time32 and time64), but there's the rub: there is no regression in the case of time32 build, but time64 just does not work in general case - for simple program it does but wine for example crashes. I suspect there are many more pieces of code scattered all around that make assumption of time bits being 32. Time64 build of box86 has never been performed in the past (cause of gcc defaulting to 32) and the source of the wine crashing lies somewhere deeper. The time64 changes have only recently started tricking down from Debian and I'm afraid that if we enable the time64 build, most users will by default build the faulty box86. Can we force TIME_BITS to 32 (just like it's been for all the time) in the main CMakeLists.txt before source of time64 problems is found?
Regards,
Krzysztof