Clarified a bit more documentation, fixed a lot of typos and removed some redundant codes.#311
Conversation
ptitSeb
reviewed
Jan 13, 2021
| * Added BOX86_SAFEMMAP env. var. | ||
| * Reworked dynarec memory manager | ||
| * Added a few opcodes | ||
| * Fixes on some float to int x86 convertions opcodes. |
Owner
There was a problem hiding this comment.
No, it is x87 actually, not x86.
x86 doesn't handle float, only x87 or SSE does.
Author
There was a problem hiding this comment.
I have changed it. Should be fine.
CHANGELOG.md
Outdated
| * FTL 1.6.9 still have corrupted music, but older 1.5.13 seems fine (different set of libs) | ||
| * Added a few wrapped libraries (like libz or some other x11 related library). | ||
| * For trace enabled build, Trace can be enabled only after a certain amount of opcodes (still, a debugger would be better). | ||
| * Some fixes in a few opcodes, and implemented x86 rounding (SuperMeatBoy behaves better now). |
Author
There was a problem hiding this comment.
I have changed it. Should be fine now.
USAGE.md
Outdated
| * 0 : default. Don't log `dlsym` error | ||
| * 1 : Log dlsym error | ||
| Enables/Disables the logging of `dlsym` errors. | ||
| * 0 |
Owner
There was a problem hiding this comment.
I'msorry but no, I really don't want 2 bullet points per options.
Author
There was a problem hiding this comment.
I have changed it, please let me know your feedback as I am unsure if I fixed it or not.
sync fork with box86
ptitSeb
reviewed
Jan 14, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I also changed the copyright year.