Uses different protocols for Python binding class ImVec2 and ImVec4 #374
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am using mypy as the type checker which complains when I am trying to add a tuple to an ImVec2:
demo.py
Run type check:
The current implementation uses a generic protocol for both ImVec2 and ImVec4.
It can not express the fact that, for example, we can add a 2-item tuple to ImVec2 but not to ImVec4,
and we can add a 4-item tuple to ImVec4 but not to ImVec2.
By using separate protocols, we can be more precise about the types that those math operators supports