Skip to content

Add python markdown div example #176

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
pthom merged 1 commit into from
Jan 30, 2024
Merged

Add python markdown div example #176

pthom merged 1 commit into from
Jan 30, 2024

Conversation

@learn-more
Copy link
Contributor

@learn-more learn-more commented Jan 30, 2024

Edited in the external/imgui_md/imgui_md_wrapper/imgui_md_wrapper.h file,
updated with py external\imgui_md\bindings\generate_imgui_md.py

@learn-more learn-more mentioned this pull request Jan 30, 2024
Merged
@pthom pthom merged commit 72b8992 into pthom:main Jan 30, 2024
@pthom
Copy link
Owner

pthom commented Jan 30, 2024

Thanks a lot, this is perfect, with the addition of having run the generator which is even more perfect. Thanks!

@learn-more learn-more deleted the comments branch January 30, 2024 22:21
@learn-more
Copy link
Contributor Author

learn-more commented Jan 30, 2024

Thanks a lot, this is perfect, with the addition of having run the generator which is even more perfect. Thanks!

Thanks!

I had to apply a small patch on the generator for it to work on Windows (without destroying the line endings),
there is a PR for that as well.

@pthom
Copy link
Owner

pthom commented Jan 31, 2024

Your contributions are first class! Do not hesitate to post more, if you so wish. I'm very opened to contributions like yours.

@learn-more
Copy link
Contributor Author

learn-more commented Feb 1, 2024

Your contributions are first class! Do not hesitate to post more, if you so wish. I'm very opened to contributions like yours.

Thank you!

I am in the process of experimenting with this bundle from c++ and python,
and considering how active you are, I will send in new patches when I encounter issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@learn-more @pthom