Skip to content

DefaultLogger.WithCaller() is broken with slog #599

@jb-abbadie

Description

@jb-abbadie

Description

The WithCaller() option of the pterm logger is broken when used with pterm.NewSlogHandler and always returns /slog_handler.go:55 as the caller

How to reproduce

package main

import (
        "log/slog"

        "github.com/pterm/pterm"
)

func main() {
        pterm.DefaultLogger.WithCaller().Info("default logger")

        logger := slog.New(pterm.NewSlogHandler(pterm.DefaultLogger.WithCaller()))
        logger.Info("slog logger")
}

expected result

2023-12-28 15:56:32 INFO  default logger caller: /tmp/slog_pterm/main.go:10
2023-12-28 15:56:32 INFO  slog logger caller: /tmp/slog_pterm/main.go:13

actual result

2023-12-28 15:56:32 INFO  default logger caller: /tmp/slog_pterm/main.go:10
2023-12-28 15:56:32 INFO  slog logger caller: /slog_handler.go:55

Impacted version

Tested with pterm v0.12.72 and Go 1.21.5

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions