BF: Better handle when stimulus stop validation fails#7485
Merged
TEParsons merged 2 commits intopsychopy:releasefrom Nov 27, 2025
Merged
BF: Better handle when stimulus stop validation fails#7485TEParsons merged 2 commits intopsychopy:releasefrom
TEParsons merged 2 commits intopsychopy:releasefrom
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## release #7485 +/- ##
===========================================
- Coverage 49.01% 49.00% -0.01%
===========================================
Files 352 352
Lines 64552 64583 +31
===========================================
+ Hits 31638 31649 +11
- Misses 32914 32934 +20
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a stimulus ends on the final frame of a Routine, its stop time can't be validated as there's no frame after display has ended on which to query the validation device. This PR handles this more cleanly by:
Nonerather than a confusing negative value (as validation is attempted on the next repeat)