BF: Fixed Mouse.getPos() returning float64 typed objects instead of float#7462
Merged
TEParsons merged 6 commits intopsychopy:releasefrom Nov 26, 2025
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## release #7462 +/- ##
===========================================
- Coverage 49.01% 49.01% -0.01%
===========================================
Files 352 352
Lines 64531 64552 +21
===========================================
+ Hits 31633 31638 +5
- Misses 32898 32914 +16
🚀 New features to boost your workflow:
|
TEParsons
requested changes
Nov 6, 2025
Contributor
TEParsons
left a comment
There was a problem hiding this comment.
From the error messages in the test suite, I think you need to catch when self.lastPos is None
Member
Author
|
Seems like the tests assume that they're getting numpy objects by performing vectorized math on them, I'll need to update all those now |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mouse coordinates are now once again returned as builtin Python
floattypes instead of NumPyfloat64objects. This mainly affected how values were written to the data file, appearing asnp.float64(<value>)instead of just the value.