Skip to content

BF: If Pavlovia API can't find a user, use pygitlab to get their user ID#7460

Merged
peircej merged 2 commits intopsychopy:releasefrom
TEParsons:release-bf-gitlab-fallback
Nov 6, 2025
Merged

BF: If Pavlovia API can't find a user, use pygitlab to get their user ID#7460
peircej merged 2 commits intopsychopy:releasefrom
TEParsons:release-bf-gitlab-fallback

Conversation

@TEParsons
Copy link
Copy Markdown
Contributor

No description provided.

@codecov
Copy link
Copy Markdown

codecov bot commented Nov 5, 2025

Codecov Report

❌ Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 49.01%. Comparing base (1e8281d) to head (23bcea9).
⚠️ Report is 5 commits behind head on release.

Additional details and impacted files
@@             Coverage Diff              @@
##           release    #7460       +/-   ##
============================================
+ Coverage    36.45%   49.01%   +12.55%     
============================================
  Files          352      352               
  Lines        64510    64514        +4     
============================================
+ Hits         23520    31622     +8102     
+ Misses       40990    32892     -8098     
Components Coverage Δ
app ∅ <ø> (∅)
boilerplate ∅ <ø> (∅)
library ∅ <ø> (∅)
vm-safe library ∅ <ø> (∅)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@TEParsons TEParsons requested a review from peircej November 5, 2025 14:49
Copy link
Copy Markdown
Member

@peircej peircej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's good but if we still don't get a gitlabId then we still want to raise an error here rather than being puzzled later. So still do the assert but do it after the gitlab users search

@TEParsons TEParsons requested a review from peircej November 6, 2025 14:58
@peircej peircej merged commit 41fe378 into psychopy:release Nov 6, 2025
3 checks passed
@TEParsons TEParsons deleted the release-bf-gitlab-fallback branch November 10, 2025 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants