BF: Fixed param control text color selection when using system dark theme#7457
Merged
TEParsons merged 4 commits intopsychopy:releasefrom Nov 7, 2025
Merged
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## release #7457 +/- ##
========================================
Coverage 49.01% 49.01%
========================================
Files 352 352
Lines 64514 64530 +16
========================================
+ Hits 31622 31631 +9
- Misses 32892 32899 +7
🚀 New features to boost your workflow:
|
TEParsons
requested changes
Nov 5, 2025
| emptyNamespace = NameSpace(experiment.Experiment()) | ||
|
|
||
| # get if dark theme | ||
| _appearanceSettings = wx.SystemSettings.GetAppearance() |
Contributor
There was a problem hiding this comment.
This seems to be breaking the test suite as it's querying wx before there's an app. I think it would make sense to move this code to a function (getDarkMode?) somewhere in utils, then import and call it when needed (e.g. in styleValid below)
Member
Author
There was a problem hiding this comment.
Addressed this by using the dark mode flag in the app's main instance
TEParsons
approved these changes
Nov 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds system wide UI theming detection (whether we're using light/dark mode) to ensure parameter text remains legible in either setting.