BF: Save unfinished mic recordings if the experiment is ended by e.g. pressing escape#7452
Merged
TEParsons merged 1 commit intopsychopy:releasefrom Oct 29, 2025
Merged
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## release #7452 +/- ##
===========================================
+ Coverage 49.00% 49.02% +0.01%
===========================================
Files 352 352
Lines 64516 64508 -8
===========================================
+ Hits 31615 31622 +7
+ Misses 32901 32886 -15
🚀 New features to boost your workflow:
|
mdcutone
approved these changes
Oct 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We're already called
saveClips, butsaveClipsdoesn't callbankso only finished recordings (i.e. the Component had finished its recording and calledbank) were saved.If there's no unfinished clips, then
bankdoes nothing, so we can afford to call this on every call tosaveClipsand it seems the best bet to catch the most use cases.