Skip to content

RF: Add a "FontFinder" for a more easily externally callable methods to get fonts known to PsychoPy#7448

Merged
TEParsons merged 2 commits intopsychopy:devfrom
TEParsons:dev-rf-font-finder
Oct 31, 2025
Merged

RF: Add a "FontFinder" for a more easily externally callable methods to get fonts known to PsychoPy#7448
TEParsons merged 2 commits intopsychopy:devfrom
TEParsons:dev-rf-font-finder

Conversation

@TEParsons
Copy link
Copy Markdown
Contributor

@TEParsons TEParsons commented Oct 24, 2025

The key things useful with this are:

  • It doesn't have to be initialised first (so it can be one liaison call rather than two)
  • Fonts can be split by source, so the front end can specify where to look and communicate what's installed where (e.g. won't be telling a user that a font file from their experiment is "installed")

I've then changed findFontFiles to use this class but return the same output, so everything downstream of that in FontManager can stay the same.

@codecov
Copy link
Copy Markdown

codecov bot commented Oct 24, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 42.85714% with 40 lines in your changes missing coverage. Please review.
✅ Project coverage is 48.93%. Comparing base (96c9ff3) to head (ebb5347).
⚠️ Report is 31 commits behind head on dev.

Additional details and impacted files 
@@            Coverage Diff             @@
##              dev    #7448      +/-   ##
==========================================
- Coverage   48.94%   48.93%   -0.02%     
==========================================
  Files         352      352              
  Lines       64848    64895      +47     
==========================================
+ Hits        31739    31754      +15     
- Misses      33109    33141      +32
Components Coverage Δ
app ∅ <ø> (∅)
boilerplate ∅ <ø> (∅)
library ∅ <ø> (∅)
vm-safe library ∅ <ø> (∅)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@TEParsons TEParsons requested a review from mdcutone October 30, 2025 14:35
@TEParsons TEParsons merged commit b1cd74a into psychopy:dev Oct 31, 2025
6 checks passed
@TEParsons TEParsons deleted the dev-rf-font-finder branch November 6, 2025 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mdcutone mdcutone mdcutone approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@TEParsons @mdcutone