Correctly get the number of joystick devices#7434
Merged
mdcutone merged 1 commit intopsychopy:devfrom Oct 20, 2025
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dev #7434 +/- ##
=======================================
Coverage 48.66% 48.66%
=======================================
Files 353 353
Lines 65121 65121
=======================================
Hits 31693 31693
Misses 33428 33428
🚀 New features to boost your workflow:
|
Contributor
|
This seems good to me, we're using |
mdcutone
approved these changes
Oct 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The method
getNumJoysticks()of the classhardware.joystickhas been removed from filepsychopy/hardware/joystick/__init__.pyin commit edca46d. However, the code in the fileexperiment/components/joystick/__init__.py(injection in the_lastrun.pyfile) has not been updated accordingly. This causes any experiment that includes the joystick component to fail, displaying the error messageNo joystick/gamepad device found. The commit in this PR seems to fix the problem.It also resolves a similar issue in the
experiment.components.joyButtonsclass.