RF: Use a dedicated param ctrl for choosing validators#7421
Merged
TEParsons merged 2 commits intopsychopy:devfrom Oct 6, 2025
Merged
RF: Use a dedicated param ctrl for choosing validators#7421TEParsons merged 2 commits intopsychopy:devfrom
TEParsons merged 2 commits intopsychopy:devfrom
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## dev #7421 +/- ##
=======================================
Coverage 48.18% 48.19%
=======================================
Files 353 353
Lines 65090 65107 +17
=======================================
+ Hits 31366 31376 +10
- Misses 33724 33731 +7
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is for compatibility with Svelte - currently, validators are listed by calling
self.getAllValidatorRoutines, but when interacting via a websocket there isn't necessarily the context ofselfso the method fails.Now, instead of needing the class context, the param supplies the relevant validator classes in
allowedVals(which is the part ofselfthat's needed to list relevant validators) so that the front end has the necessary data to handle it.