BF: ExperimentHandler not saving extraInfo to wide text#7374
Merged
TEParsons merged 1 commit intopsychopy:devfrom Dec 10, 2025
Merged
BF: ExperimentHandler not saving extraInfo to wide text#7374TEParsons merged 1 commit intopsychopy:devfrom
TEParsons merged 1 commit intopsychopy:devfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dev #7374 +/- ##
==========================================
- Coverage 12.18% 12.18% -0.01%
==========================================
Files 353 353
Lines 64940 64940
==========================================
- Hits 7912 7911 -1
- Misses 57028 57029 +1
🚀 New features to boost your workflow:
|
Contributor
|
Seems a good solution, thanks for catching this! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I recently updated my PsychoPy, and noticed the
ExperimentHandlerwas no longer saving the fields in theextraInfodictionary to the wide text/csv file. I think this is due to a recent change where theextraInfogets stored as PsychoPy's newIndexDictobject. This was causing checks for the type of theextraInfoobject to fail, as it isn't a normal Python dictionary any more. Seeing asIndexDictinherits fromdict, just changing the checks to useisinstancerather thantype == dictseems to fix the problem.