BF: Handle when allowedKeys is just 1 multi-character string (e.g. "return") online#7268
Merged
TEParsons merged 1 commit intopsychopy:releasefrom Jun 2, 2025
Merged
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release #7268 +/- ##
========================================
Coverage 12.28% 12.28%
========================================
Files 346 346
Lines 64013 64013
========================================
Hits 7865 7865
Misses 56148 56148
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, supplying just
"return"as allowed keys acts as if you'd supplied["r", "e", "t", "u", "r", "n"]and not["return"]There's an easy workaround (just supply
["return"]or"return",) but we should really just handle this use case.