Skip to content

BF: Fix erronious alert when using any local transcriber#7258

Merged
TEParsons merged 1 commit intopsychopy:releasefrom
TEParsons:release-bf-transcriber-alert
May 21, 2025
Merged

BF: Fix erronious alert when using any local transcriber#7258
TEParsons merged 1 commit intopsychopy:releasefrom
TEParsons:release-bf-transcriber-alert

Conversation

@TEParsons
Copy link
Copy Markdown
Contributor

Basically, we were checking for the key in localTranscriebrs rather than the value, so it was always behaving as if an invalid transcriber was chosen & was showing an unnecessary alert.

Fixes #7192

@codecov
Copy link
Copy Markdown

codecov bot commented May 21, 2025

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 12.24%. Comparing base (371afc1) to head (70eaa2e).
Report is 5 commits behind head on release.

Additional details and impacted files
@@             Coverage Diff             @@
##           release    #7258      +/-   ##
===========================================
+ Coverage    12.18%   12.24%   +0.06%     
===========================================
  Files          346      347       +1     
  Lines        64010    64344     +334     
===========================================
+ Hits          7800     7880      +80     
- Misses       56210    56464     +254     
Components Coverage Δ
app ∅ <ø> (∅)
boilerplate ∅ <ø> (∅)
library ∅ <ø> (∅)
vm-safe library ∅ <ø> (∅)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@TEParsons TEParsons changed the base branch from dev to release May 21, 2025 14:14
@TEParsons TEParsons merged commit 7126992 into psychopy:release May 21, 2025
7 checks passed
@TEParsons TEParsons deleted the release-bf-transcriber-alert branch May 21, 2025 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Using Whisper OpenAI transcription only available offline even when installed?

1 participant