EN: Track installed files to prevent accidental deletion of user files during uninstallation#7175
Merged
peircej merged 6 commits intopsychopy:devfrom Mar 27, 2025
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #7175 +/- ##
=======================================
Coverage 12.26% 12.27%
=======================================
Files 346 346
Lines 64006 63999 -7
=======================================
+ Hits 7853 7854 +1
+ Misses 56153 56145 -8
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a script to the build pipeline which generates a NSIS script include which explicitly tracks and deletes files which we installed.
This is necessary to prevent users for deleting their own files if they install PsychoPy to a non-standard location containing other files.