Skip to content

BF: Better handle (and warn about) deprecated color attributes#7127

Merged
TEParsons merged 2 commits intopsychopy:devfrom
TEParsons:dev-bf-color-legacy
Feb 24, 2025
Merged

BF: Better handle (and warn about) deprecated color attributes#7127
TEParsons merged 2 commits intopsychopy:devfrom
TEParsons:dev-bf-color-legacy

Conversation

@TEParsons
Copy link
Copy Markdown
Contributor

Core changes:

  • Rather than relying on False to distinguish between "not set" and "set as None", I've made a dedicated constant for it (undefined, a singleton instance of UndefinedType)
  • At the BaseShapeLevel, if any of the legacy attributes are not undefined, warn the user and list the correct attribute

@codecov
Copy link
Copy Markdown

codecov bot commented Feb 24, 2025

Codecov Report

Attention: Patch coverage is 94.73684% with 2 lines in your changes missing coverage. Please review.

Project coverage is 49.90%. Comparing base (ea1b7e9) to head (005991f).
Report is 6 commits behind head on dev.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #7127   +/-   ##
=======================================
  Coverage   49.89%   49.90%           
=======================================
  Files         346      346           
  Lines       63990    63994    +4     
=======================================
+ Hits        31929    31934    +5     
+ Misses      32061    32060    -1     
Components Coverage Δ
app ∅ <ø> (∅)
boilerplate ∅ <ø> (∅)
library ∅ <ø> (∅)
vm-safe library ∅ <ø> (∅)

@TEParsons TEParsons merged commit 331b9f8 into psychopy:dev Feb 24, 2025
7 checks passed
@TEParsons TEParsons deleted the dev-bf-color-legacy branch May 21, 2025 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant