RF: Applied augmented assignment (x += y rather than x = x + y) where applicable (#4385)#7114
Merged
TEParsons merged 1 commit intopsychopy:devfrom Apr 16, 2025
Merged
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #7114 +/- ##
=======================================
Coverage 49.89% 49.89%
=======================================
Files 346 346
Lines 64012 64004 -8
=======================================
+ Hits 31936 31937 +1
+ Misses 32076 32067 -9
🚀 New features to boost your workflow:
|
mdcutone
approved these changes
Feb 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR refactors multiple instances of simple assignments to use augmented assignment statements (+=, -=, *=, etc.) where applicable. This improves code readability and efficiency.
Changes Made:
Replaced mouseWheelRel = mouseWheelRel + numpy.array([scroll_x, scroll_y]) with mouseWheelRel += numpy.array([scroll_x, scroll_y]) in psychopy/event.py.
Optimized scrX = scrX + (self.size[0] / 2.) to scrX += self.size[0] / 2. in psychopy/visual/window.py.
Updated frameN = frameN + 1 to frameN += 1 in psychopy/tests/data/correctScript/python/correctNoiseStimComponent.py.
Issue Reference:
Closes #4385