BF: Parameters weren't being set on first frame in JS#7113
Merged
TEParsons merged 2 commits intopsychopy:devfrom Feb 18, 2025
Merged
BF: Parameters weren't being set on first frame in JS#7113TEParsons merged 2 commits intopsychopy:devfrom
TEParsons merged 2 commits intopsychopy:devfrom
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #7113 +/- ##
==========================================
+ Coverage 49.89% 49.90% +0.01%
==========================================
Files 346 346
Lines 64012 64008 -4
==========================================
+ Hits 31936 31942 +6
+ Misses 32076 32066 -10
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because they're set each frame that the stimulus is STARTED, they're not set on the first frame that it's drawn because the check for STARTED (and subsequent param setting) happens before STARTED is set that frame. This PR adds lines to set params when starting a Component as well as each frame it's active.