BF: Coder file modified dialog shouldn't block Builder#7111
Merged
TEParsons merged 3 commits intopsychopy:devfrom Feb 17, 2025
Merged
BF: Coder file modified dialog shouldn't block Builder#7111TEParsons merged 3 commits intopsychopy:devfrom
TEParsons merged 3 commits intopsychopy:devfrom
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #7111 +/- ##
=======================================
Coverage 49.89% 49.89%
=======================================
Files 346 346
Lines 64012 64004 -8
=======================================
Hits 31936 31936
+ Misses 32076 32068 -8
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Showing the "File was modified outside PsychoPy..." dialog as modal (blocks user from doing anything while it's open) makes sense for Coder, but because it was fully modal it blocks Builder and Runner too when it doesn't need to.
Unfortunately,
ShowWindowModalonly works on Mac - on Windows it behaves the same asShowModal, but I think it makes sense to go with the one which at least works on one OS.I've also made it so the dialog is pushed to the front upon opening, so that the user at least knows it's there (it's annoying when Builder pings at you and you don't know why)