BF: Fix timing issue when a non-slip Routine was force ended in JS#7110
Merged
TEParsons merged 1 commit intopsychopy:devfrom Feb 17, 2025
Merged
BF: Fix timing issue when a non-slip Routine was force ended in JS#7110TEParsons merged 1 commit intopsychopy:devfrom
TEParsons merged 1 commit intopsychopy:devfrom
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #7110 +/- ##
=======================================
Coverage 49.89% 49.89%
=======================================
Files 346 346
Lines 64012 64012
=======================================
Hits 31936 31936
Misses 32076 32076
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because PsychoJS doesn't know the difference between a Routine being force ended and a Routine ending because all its Components finished, it was possible to mess up timings by force ending a Routine which Builder identified as nonslip (as at Routine end it would subtract the total time, even though the total time hadn't passed). Solution is to keep track of when a Routine is force ended, and if it has do a
resetinstead.