Skip to content

RF: Remove sampleRate and channels params from Microphone, both of these can be detected reliably now#7090

Merged
TEParsons merged 1 commit intopsychopy:devfrom
TEParsons:dev-bf-remove-mic-params-2
Feb 7, 2025
Merged

RF: Remove sampleRate and channels params from Microphone, both of these can be detected reliably now#7090
TEParsons merged 1 commit intopsychopy:devfrom
TEParsons:dev-bf-remove-mic-params-2

Conversation

@TEParsons
Copy link
Copy Markdown
Contributor

No description provided.

@TEParsons TEParsons changed the title BF: Remove sampleRate and channels params from Microphone, both of these can be detected reliably now ENH: Remove sampleRate and channels params from Microphone, both of these can be detected reliably now Feb 7, 2025
@codecov
Copy link
Copy Markdown

codecov bot commented Feb 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 49.99%. Comparing base (a7b2cb6) to head (7e279e9).
Report is 11 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #7090      +/-   ##
==========================================
- Coverage   49.99%   49.99%   -0.01%     
==========================================
  Files         347      347              
  Lines       64062    64039      -23     
==========================================
- Hits        32028    32014      -14     
+ Misses      32034    32025       -9     
Components Coverage Δ
app ∅ <ø> (∅)
boilerplate ∅ <ø> (∅)
library ∅ <ø> (∅)
vm-safe library ∅ <ø> (∅)

@TEParsons TEParsons merged commit 0bc1eea into psychopy:dev Feb 7, 2025
7 checks passed
@TEParsons TEParsons changed the title ENH: Remove sampleRate and channels params from Microphone, both of these can be detected reliably now RF: Remove sampleRate and channels params from Microphone, both of these can be detected reliably now Feb 7, 2025
@TEParsons TEParsons deleted the dev-bf-remove-mic-params-2 branch February 12, 2025 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant