ENH: Ask in Builder before downloading a Google Font#7082
Merged
TEParsons merged 8 commits intopsychopy:devfrom Feb 7, 2025
Merged
ENH: Ask in Builder before downloading a Google Font#7082TEParsons merged 8 commits intopsychopy:devfrom
TEParsons merged 8 commits intopsychopy:devfrom
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #7082 +/- ##
==========================================
- Coverage 49.99% 49.97% -0.03%
==========================================
Files 347 347
Lines 64062 64061 -1
==========================================
- Hits 32028 32013 -15
- Misses 32034 32048 +14
|
added 6 commits
February 6, 2025 13:49
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, if a font isn't found, we download it from Google Fonts and print a warning. However, if the user doesn't have an internet connection, this leads to a ConnectionError on every run if they have a typo in a font name. In general it also just doesn't seem like a good idea to be making a call to
requestsin runtime.This PR moves the Google Font checking out to Builder, allowing us to ask the user before connecting (upon clicking "Okay" on the Component dialog) rather than warning them after.