BF: If a Mic was never started, it would error on saving recording#7076
Merged
TEParsons merged 2 commits intopsychopy:devfrom Jan 31, 2025
Merged
BF: If a Mic was never started, it would error on saving recording#7076TEParsons merged 2 commits intopsychopy:devfrom
TEParsons merged 2 commits intopsychopy:devfrom
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #7076 +/- ##
==========================================
+ Coverage 40.86% 49.99% +9.13%
==========================================
Files 347 347
Lines 64056 64062 +6
==========================================
+ Hits 26174 32030 +5856
+ Misses 37882 32032 -5850
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because
.bankis called by Builder whether or not the Component actually started (so whether or not the recording is empty) - but callingbankon a mic with an empty recording means thatmic.clipsgets aNoneappended. Fix is to instead store an empty AudioClip.